Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: make local build pass #17438
Open
fix: make local build pass #17438
Conversation
manekinekko
force-pushed the
manekinekko:fix-local-build
branch
from
cb3c099
to
6bf1892
Closes #17437
manekinekko
force-pushed the
manekinekko:fix-local-build
branch
from
6bf1892
to
56181ec
| @@ -164,7 +164,7 @@ function _getVersionFromGit(experimental: boolean): string { | |||
| } | |||
|
|
|||
| const hasLocalChanges = _exec(`git status --porcelain`) != ''; | |||
| const scmVersionTagRaw = _exec(`git describe --match v[0-9]*.[0-9]*.[0-9]* --abbrev=7 --tags`) | |||
| const scmVersionTagRaw = _exec(`git describe --match v[0-9]*.[0-9]*.[0-9]* --abbrev=7 --tags --always`) | |||
alan-agius4
Apr 10, 2020
•
Collaborator
This doesn't seem right, because --always will return commit SHA and not a tag version.
I think the original problem is that tags were not fetched or are not in sync with upstream.
PS: in such case commit msg should be build:
This doesn't seem right, because --always will return commit SHA and not a tag version.
I think the original problem is that tags were not fetched or are not in sync with upstream.
PS: in such case commit msg should be build:
manekinekko
Apr 10, 2020
Author
Member
I will update the commit message.
FYI, this was a fresh build (on a new computer) and followed the installation guide.
I will update the commit message.
FYI, this was a fresh build (on a new computer) and followed the installation guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes #17437