Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Default tag_name and release_name to be `github.ref` #53
Conversation
jasonkarns
changed the title
|
closes #26 |
|
@jasonkarns Additionally please remove the Currently, it is displaying like this: |
|
@shivapoudel I'm not against that, but doing so would be a more invasive change that would decrease the chance this PR gets merged. Perhaps open as a separate PR? |
|
@jasonkarns Thanks for the suggestion, I have raised a PR #66 for this separately. |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
For most workflows (indeed, even in the example for this action), this action will be scoped to only run for version tags. So for most workflows, it is highliy likely that the tag-name for the release ought to be the same as
${{ github.ref }}. In the spirit of convention over configuration, that would make a desirable default.Similarly for the release_name. This actually results in the same behavior as when creating a release manually through the UI (the default release name is the same as the tag name, unless given explicitly).
(Pattern of setting defaults via expression directly in the manifest taken from actions/checkout.)