close
The Wayback Machine - https://web.archive.org/web/20201207231013/https://github.com/Kitware/fletch/pull/408
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extra Flag for OpenCV Using TIFF #408

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@mattdawkins
Copy link
Member

@mattdawkins mattdawkins commented Jul 11, 2018

No description provided.

)
# Allow OpenCV's tiff support to be turned off
option(fletch_ENABLE_OpenCV_TIFF "Build OpenCV with tiff image support" TRUE )
mark_as_advanced(fletch_ENABLE_OpenCV_TIFF)

This comment has been minimized.

@dstoup

dstoup Jul 13, 2018
Collaborator

I'm not really in favor of these kinds of arguments. It opens a an endless permutations for every package that can deal with every image format. We've always followed the practice that if you enable something in fletch support for it is added. Is there a good reason to force disable? If so, there needs to be a better approach (better engineering) in place that doesn't involve adding these flags for every package. This type of thing requires a larger discussion.

This comment has been minimized.

@mattdawkins

mattdawkins Aug 3, 2018
Author Member

People were reporting build issues in VIAME because of this on a few linux platforms, leaving it turned off resolved said issues, because tiff support in opencv is un-needed in VIAME

This comment has been minimized.

@dstoup

dstoup Aug 6, 2018
Collaborator

You're welcome to merge this branch into viame/master if that helps. If you could provide details about the error we might be able to resolve it. I haven't seen any issues thus far.

This comment has been minimized.

@mattdawkins

mattdawkins Aug 6, 2018
Author Member

It has been, for some time, and viame/master will continue to exist if this isn't merged into master, which is fine by me, but otherwise we could have pegged it to master.

This comment has been minimized.

@mattdawkins

mattdawkins Aug 6, 2018
Author Member

The errors themselves were primarily linking errors on Ubuntu / Fedora, didn't have time to deal with at the time and still don't, it was better for us to just leave it disabled since it's un-needed

This comment has been minimized.

@dstoup

dstoup Aug 14, 2018
Collaborator

Link errors from viame/master or master? There are a lot of fixes in master which relate to this problem.

This comment has been minimized.

@dstoup

dstoup Aug 14, 2018
Collaborator

If you can point me to an instance of a build failure, I will take a look at fixing this the right way, if possible.

This comment has been minimized.

@mattdawkins

mattdawkins Aug 15, 2018
Author Member

viame/master on fletch is close to master, so both. Reproducing is low priority right now, won't happen for a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.