Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add Extra Flag for OpenCV Using TIFF #408
Conversation
| ) | ||
| # Allow OpenCV's tiff support to be turned off | ||
| option(fletch_ENABLE_OpenCV_TIFF "Build OpenCV with tiff image support" TRUE ) | ||
| mark_as_advanced(fletch_ENABLE_OpenCV_TIFF) |
dstoup
Jul 13, 2018
Collaborator
I'm not really in favor of these kinds of arguments. It opens a an endless permutations for every package that can deal with every image format. We've always followed the practice that if you enable something in fletch support for it is added. Is there a good reason to force disable? If so, there needs to be a better approach (better engineering) in place that doesn't involve adding these flags for every package. This type of thing requires a larger discussion.
I'm not really in favor of these kinds of arguments. It opens a an endless permutations for every package that can deal with every image format. We've always followed the practice that if you enable something in fletch support for it is added. Is there a good reason to force disable? If so, there needs to be a better approach (better engineering) in place that doesn't involve adding these flags for every package. This type of thing requires a larger discussion.
mattdawkins
Aug 3, 2018
Author
Member
People were reporting build issues in VIAME because of this on a few linux platforms, leaving it turned off resolved said issues, because tiff support in opencv is un-needed in VIAME
People were reporting build issues in VIAME because of this on a few linux platforms, leaving it turned off resolved said issues, because tiff support in opencv is un-needed in VIAME
dstoup
Aug 6, 2018
Collaborator
You're welcome to merge this branch into viame/master if that helps. If you could provide details about the error we might be able to resolve it. I haven't seen any issues thus far.
You're welcome to merge this branch into viame/master if that helps. If you could provide details about the error we might be able to resolve it. I haven't seen any issues thus far.
mattdawkins
Aug 6, 2018
Author
Member
It has been, for some time, and viame/master will continue to exist if this isn't merged into master, which is fine by me, but otherwise we could have pegged it to master.
It has been, for some time, and viame/master will continue to exist if this isn't merged into master, which is fine by me, but otherwise we could have pegged it to master.
mattdawkins
Aug 6, 2018
Author
Member
The errors themselves were primarily linking errors on Ubuntu / Fedora, didn't have time to deal with at the time and still don't, it was better for us to just leave it disabled since it's un-needed
The errors themselves were primarily linking errors on Ubuntu / Fedora, didn't have time to deal with at the time and still don't, it was better for us to just leave it disabled since it's un-needed
dstoup
Aug 14, 2018
Collaborator
Link errors from viame/master or master? There are a lot of fixes in master which relate to this problem.
Link errors from viame/master or master? There are a lot of fixes in master which relate to this problem.
dstoup
Aug 14, 2018
Collaborator
If you can point me to an instance of a build failure, I will take a look at fixing this the right way, if possible.
If you can point me to an instance of a build failure, I will take a look at fixing this the right way, if possible.
mattdawkins
Aug 15, 2018
Author
Member
viame/master on fletch is close to master, so both. Reproducing is low priority right now, won't happen for a bit
viame/master on fletch is close to master, so both. Reproducing is low priority right now, won't happen for a bit

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

No description provided.