Conversation
|
This pull request is being automatically deployed with Vercel (learn more). |
|
|
||
| return String(string).replace(/[&<>"']/g, s => entityMap[s]); | ||
| function ClearLabelStyle () { | ||
| console.log('ClearLabelStyle tetiklendi') |
There was a problem hiding this comment.
Console.log should be removed.
@sy-records That's true. I had asked @H91011 to open this PR so we could see what his search plugin does. But build didn't succeed. @H91011 Does |
|
@H91011 Are the changes backwards-compatible (in case we decide to move forward with something later)? Nite at the moment we're getting test infrastructure in place and stabilizing the code before we try to add new features. But if you can get this pull request working so that the build is green, that would be awesome! You can check the build logs here (click "Details") to see why it failed. Also you should be able to run the commands on your local system too, f.e. |
Koooooo-7
left a comment
Koooooo-7
left a comment
There was a problem hiding this comment.
Does it still work in process, or it seems out of date.
| for (let i = 0; i < data.length; i++) { | ||
| const post = data[i]; | ||
| let matchesScore = 0; | ||
| let resultStr = ''; |
There was a problem hiding this comment.
if you have moved the score metric, what's the rules that sorting the similar match results.
5 participants
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.