Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
feat: honor displayName of context types #18224
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2176e6d:
|
Details of bundled changes.Comparing: 3ee812e...2176e6d react
React: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 3ee812e...2176e6d react
React: size: 0.0%, gzip: 0.0% Size changes (experimental) |
|
I ran a local sync on this version and verified that the internal test the previous PR broke passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
New iteration of #18035 which had to be reverted (#18223) since setting
Context.Consumer.displayNamewould throw.Setting
Context.Consumer.displayNameignores the given value but emits warning. As far as I can tell this doesn't do anything onmaster: https://codesandbox.io/s/priceless-hooks-lm0kyTest Plan
@trueadm should sign this off since this affects internal tests. If a warning is still too loud we could put it behind a flag that we turn off for the fb builds.