close
The Wayback Machine - https://web.archive.org/web/20201228035711/https://github.com/microsoft/vscode-java-dependency/pull/402
Skip to content

/ vscode-java-dependency

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Error reporting and null check in export jar #402

Merged
merged 5 commits into from Dec 9, 2020
Merged

refactor: Error reporting and null check in export jar #402

merged 5 commits into from Dec 9, 2020

Conversation

@CsCherrYY
Copy link
Contributor

@CsCherrYY CsCherrYY commented Dec 7, 2020

Fix #385

This PR fixs:

  1. Enables null check and implicit any for export jar files
  2. Refactor error reporting and telemetry sending in export jar.
@CsCherrYY
Refactor error reporting and null check in export jar
Loading status checks…
3ceb304
@CsCherrYY CsCherrYY force-pushed the exportJarNullCheck branch from 5eda89a to 3ceb304 Dec 7, 2020
@CsCherrYY CsCherrYY changed the title Refactor: Error reporting and null check in export jar refactor: Error reporting and null check in export jar Dec 7, 2020
@jdneo
jdneo requested changes Dec 8, 2020
View changes
src/exportJarSteps/GenerateJarExecutor.ts Outdated Show resolved Hide resolved
src/exportJarSteps/GenerateJarExecutor.ts Outdated Show resolved Hide resolved
src/exportJarSteps/GenerateJarExecutor.ts Outdated Show resolved Hide resolved
src/exportJarSteps/ResolveJavaProjectExecutor.ts Outdated Show resolved Hide resolved
src/exportJarSteps/utility.ts Outdated Show resolved Hide resolved
CsCherrYY added 2 commits Dec 8, 2020
@CsCherrYY
Address comments
Loading status checks…
d067583
@CsCherrYY
Remove unnecessary codes
Loading status checks…
6363468
@jdneo
jdneo requested changes Dec 8, 2020
View changes
src/exportJarSteps/GenerateJarExecutor.ts Outdated Show resolved Hide resolved
src/exportJarSteps/GenerateJarExecutor.ts Outdated Show resolved Hide resolved
src/exportJarSteps/ExportJarTaskProvider.ts Outdated Show resolved Hide resolved
src/exportJarSteps/ExportJarTaskProvider.ts Outdated Show resolved Hide resolved
src/exportJarSteps/ExportJarTaskProvider.ts Outdated Show resolved Hide resolved
src/exportJarSteps/ExportJarTaskProvider.ts Outdated Show resolved Hide resolved
src/exportJarSteps/ExportJarTaskProvider.ts Outdated Show resolved Hide resolved
jdneo and others added 2 commits Dec 8, 2020
@jdneo
Merge branch 'master' into exportJarNullCheck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
87cd5f9
@CsCherrYY
Address the comments and remove undefined fields
Loading status checks…
e25c12e
@jdneo jdneo added the eng label Dec 9, 2020
@jdneo jdneo added this to the 0.16.0 milestone Dec 9, 2020
@jdneo
jdneo approved these changes Dec 9, 2020
View changes
@jdneo jdneo merged commit 26a86e8 into master Dec 9, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@jdneo
Copy link
Member

@jdneo jdneo commented Dec 9, 2020

Thanks @CsCherrYY
@jdneo jdneo deleted the exportJarNullCheck branch Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo

Assignees
No one assigned
Labels
eng
Projects
None yet
Milestone
0.16.0
Linked issues

Successfully merging this pull request may close these issues.

Rewrite error handing in export jar
2 participants
@CsCherrYY @jdneo
You can’t perform that action at this time.