close
The Wayback Machine - https://web.archive.org/web/20201223144117/https://github.com/freeCodeCamp/devdocs/pull/1356
Skip to content

/ devdocs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy: add versions 1.18 and 1.19 #1356

Draft
wants to merge 1 commit into
base: master
from
Draft

numpy: add versions 1.18 and 1.19 #1356

wants to merge 1 commit into from

Conversation

@simon04
Copy link
Contributor

@simon04 simon04 commented Nov 19, 2020 •
edited

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

The entries need some additional cleanup…

Screenshot_2020-11-19 NumPy 1 18 documentation — DevDocs

Fixes #1352.
@simon04
numpy: add versions 1.18 and 1.19
Loading status checks…
438f8ab
@simon04 simon04 requested a review from freeCodeCamp/devdocs as a code owner Nov 19, 2020
@simon04 simon04 marked this pull request as draft Nov 19, 2020
@simon04
Copy link
Contributor Author

@simon04 simon04 commented Nov 24, 2020

@MasterEnoc, @scherepn, feel free to pick up this draft PR. I'm unsure when I can finish this one myself…
@scherepn scherepn mentioned this pull request Dec 22, 2020
Open
@scherepn
Copy link
Contributor

@scherepn scherepn commented Dec 23, 2020

Took a brief look at this and found a few problems immediately. They all look related to updates/changes in Sphinx. Newer versions changed formatting/tags and everything could use a revisiting. I discovered a few problems and opportunities for improvements in sphinx/clean_html and sphinx.scss while working on scikit-image and scikit-learn.

This could be be part of a wider 'improve sphinx common code'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeCodeCamp/devdocs devdocs

Assignees
No one assigned
Labels
docs/update
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

numpy outdated
2 participants
@simon04 @scherepn
You can’t perform that action at this time.