close
The Wayback Machine - https://web.archive.org/web/20201224035922/https://github.com/javascript-tutorial/es.javascript.info/pull/314
Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic operators, maths #314

Merged
merged 15 commits into from Jul 23, 2020
Merged

Basic operators, maths #314

merged 15 commits into from Jul 23, 2020

Conversation

@EzequielCaste
Copy link
Contributor

@EzequielCaste EzequielCaste commented Jul 22, 2020

No description provided.

@EzequielCaste
traducción completa de 08 operators
Loading status checks…
5b36995
@EzequielCaste EzequielCaste requested a review from vplentinax Jul 22, 2020
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 22, 2020
@EzequielCaste EzequielCaste changed the title traducción completa de 08 operators Basic operators, maths Jul 22, 2020
@iliakan iliakan mentioned this pull request Jul 22, 2020
Open
159 of 174 tasks complete
@joaquinelio joaquinelio self-requested a review Jul 22, 2020
@joaquinelio
joaquinelio requested changes Jul 22, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment •
edited

¡Uh, miren quén está vivo!
¿Un año sabático de un par de dias?
qué perezoso

Con este aporte casi se lee de corrido la primera parte!!!!!!
salvo el exmantainer ric

edit:
ah, no da para review, pero la version inglés 1 2 8 3 solution,
hacen "fix" (¿?) agregan ESPACIOS en lineas 13 y 14... NO ENTIEDO POR QUÉ

edit2:
No está basado en el EN de hace 3 meses
cambia def, titulos y agrega algunas linas al articulo
1-js/02-first-steps/08-operators/1-increment-order/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/1-increment-order/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/1-increment-order/task.md Outdated Show resolved Hide resolved
...2-first-steps/08-operators/3-primitive-conversions-questions/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/3-primitive-conversions-questions/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 22, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
EzequielCaste and others added 10 commits Jul 22, 2020
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7d34563 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a11a915 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/1-increment-order/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
500d8e5 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/3-primitive-conversions-quest…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b14e252 
…ions/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/3-primitive-conversions-quest…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ef70003 
…ions/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0b01e8b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3fb8d40 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5a008f3 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
01716b7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste
Update 1-js/02-first-steps/08-operators/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
470f5f8
@EzequielCaste
Copy link
Contributor Author

@EzequielCaste EzequielCaste commented Jul 22, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 22, 2020
@EzequielCaste EzequielCaste removed request for javascript-tutorial/translate-es and vplentinax Jul 23, 2020
@EzequielCaste @joaquinelio
Update 1-js/02-first-steps/08-operators/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4104623 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
joaquinelio approved these changes Jul 23, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

NO LO RELEÍ apenass miré lo que puso maksumi.
Supongo que arreglaste los tipos,
y solo te disscutiría los err de concepto pero no había visto ninguno, so...
apruebo sin leer.
@maksumi
maksumi approved these changes Jul 23, 2020
View changes
Copy link
Collaborator

@maksumi maksumi left a comment

Solo hay unas nuevas sugerencias que veo necesarias, consideralaspor favor. De ahí en fuera: approve!
1-js/02-first-steps/08-operators/1-increment-order/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/1-increment-order/solution.md Outdated Show resolved Hide resolved
...2-first-steps/08-operators/3-primitive-conversions-questions/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/4-fix-prompt/solution.md

```js run
let a = "1"; // prompt("First number?", 1);
let b = "2"; // prompt("Second number?", 2);
let a = "1"; // prompt("Primer número?", 1);

This comment has been minimized.

Sign in to view
@maksumi

maksumi Jul 23, 2020
Collaborator

De hecho no... Leelo con tono de pregunta. @joaquinelio
EzequielCaste and others added 3 commits Jul 23, 2020
@EzequielCaste @maksumi
Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fa1f7d2 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@EzequielCaste @maksumi
Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b83d4b1 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@EzequielCaste @maksumi
Update 1-js/02-first-steps/08-operators/3-primitive-conversions-quest…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ec1088a 
…ions/solution.md

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@EzequielCaste EzequielCaste merged commit 33f3ea4 into javascript-tutorial:master Jul 23, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 23, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@maksumi maksumi

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@EzequielCaste @javascript-translate-bot @joaquinelio @maksumi
You can’t perform that action at this time.