close
The Wayback Machine - https://web.archive.org/web/20210817023459/https://github.com/atom/language-php/pull/394
Skip to content

/ language-php

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta.use end regex #394

Merged
merged 2 commits into from Aug 11, 2020
Merged

Fix meta.use end regex #394

merged 2 commits into from Aug 11, 2020

Conversation

@sadick254
Copy link
Contributor

@sadick254 sadick254 commented Jul 15, 2020

Description of the Change

Add a positive lookahead regex to allow use of optional semicolon on the use operator without breaking the syntax highlighting.

Alternate Designs

N/A

Benefits

Allow usage of optional semicolon on the use operator

Possible Drawbacks

Not that I can think of at the moment.

Applicable Issues

Resolves #364
sadick254 added 2 commits Jul 15, 2020
@sadick254
Fix meta.use end regex
11cdaf6
@sadick254
Fix linting
7d0bb94
@sadick254 sadick254 marked this pull request as ready for review Jul 15, 2020
@lkashef lkashef requested review from lkashef and darangi Jul 15, 2020
@sadick254 sadick254 merged commit b1281fa into atom:master Aug 11, 2020
1 check passed
1 check passed
Image
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sadick254 sadick254 deleted the sadick254:fix-use-regex branch Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkashef lkashef

@darangi darangi

Assignees

@sadick254 sadick254

Labels
needs-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

The use operator and optional semicolon before closing tag
1 participant
@sadick254