close
The Wayback Machine - https://web.archive.org/web/20210210194016/https://github.com/github/linguist/pull/5182
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for record-jar files #5182

Merged
merged 5 commits into from Feb 10, 2021
Merged

Add support for record-jar files #5182

merged 5 commits into from Feb 10, 2021

Conversation

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Feb 4, 2021

This pull-request adds support for the record-jar format, the best-known example of which (and the only one with sufficient distribution) is the IANA language subtag registry.

More background on this format can be found at a 7-year old repository of mine, which actually does a pretty good job of explaining it.

Distribution

Syntax highlighting samples

Origin of sample

Freely distributed by IANA and released to the public domain.

Rationale for colour choice

I picked #0673ba from IANA's logo, because record-jars (like most Unix text-file formats) don't have any "branding" so to speak.

@Alhadis Alhadis requested a review from github/linguist as a code owner Feb 4, 2021
@lildude
Copy link
Member

@lildude lildude commented Feb 8, 2021

Origin of sample

Freely distributed by IANA and released to the public domain.

Whooopsie, looks like we're missing a commit as there isn't a sample on this PR at the mo 😉

@Alhadis
Copy link
Collaborator Author

@Alhadis Alhadis commented Feb 9, 2021

@lildude Whoops. Fixed.

@lildude
Copy link
Member

@lildude lildude commented Feb 9, 2021

Woah! It's hooog!! But I see it's pretty much the same file in every repo.

@lildude
lildude approved these changes Feb 9, 2021
@lildude lildude merged commit 72efcaf into master Feb 10, 2021
10 checks passed
10 checks passed
Ruby 2.7
Details
Ruby 2.7
Details
Ruby 2.6
Details
Ruby 2.6
Details
Ruby 2.5
Details
Ruby 2.5
Details
Test Dockerfile
Details
Test Dockerfile
Details
Classifier cross-validation
Details
Classifier cross-validation
Details
@lildude lildude deleted the record-jar branch Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants