close
The Wayback Machine - https://web.archive.org/web/20210505153736/https://github.com/storybookjs/storybook/issues/14513
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global types added to the toolbar are illegible when using OSX dark theme #14513

Open
randak opened this issue Apr 8, 2021 · 3 comments
Open

Global types added to the toolbar are illegible when using OSX dark theme #14513

randak opened this issue Apr 8, 2021 · 3 comments

Comments

@randak
Copy link
Contributor

@randak randak commented Apr 8, 2021

Describe the bug
A clear and concise description of what the bug is.
The dropdown menu on the global types that are defined in the menu is displayed with black text on a black background when using a Mac with dark theme.

To Reproduce
Steps to reproduce the behavior:

  1. Install the Storybook a11y add-on or define a global type
  2. Set Mac to dark theme
  3. Click on one of the menus in the toolbar
  4. See that you cannot read anything

Expected behavior
A clear and concise description of what you expected to happen.

The menu should not change background color when dark theme is set, or at least the text should also change color.

Screenshots
If applicable, add screenshots to help explain your problem.
Screen Shot 2021-04-05 at 3 26 39 PM

This one struck me as particularly ironic:
Screen Shot 2021-04-08 at 10 49 11 AM

Code snippets
If applicable, add code samples to help explain your problem.

System
Please paste the results of npx sb@next info here.

% npx sb@next info

Environment Info:

  System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 12.21.0 - /usr/local/opt/node@12/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.11 - /usr/local/opt/node@12/bin/npm
  Browsers:
    Chrome: 89.0.4389.114
    Safari: 13.1.3
  npmPackages:
    @storybook/addon-a11y: 6.2.2 => 6.2.2 
    @storybook/addon-actions: 6.2.2 => 6.2.2 
    @storybook/addon-essentials: 6.2.2 => 6.2.2 
    @storybook/addon-knobs: 6.2.2 => 6.2.2 
    @storybook/addon-links: 6.2.2 => 6.2.2 
    @storybook/addon-postcss: ^2.0.0 => 2.0.0 
    @storybook/addon-storysource: 6.2.2 => 6.2.2 
    @storybook/addons: 6.2.2 => 6.2.2 
    @storybook/react: 6.2.2 => 6.2.2 
    @storybook/source-loader: 6.2.2 => 6.2.2 
    @storybook/storybook-deployer: ^2.8.7 => 2.8.7 
    @storybook/theming: 6.2.2 => 6.2.2 

Additional context
Add any other context about the problem here.

@blankwavearcade
Copy link

@blankwavearcade blankwavearcade commented Apr 9, 2021

Hi, I’d like to work this issue.

@shilman
Copy link
Member

@shilman shilman commented Apr 9, 2021

Thanks @blankwavearcade! 🙏

@randak
Copy link
Contributor Author

@randak randak commented Apr 15, 2021

@blankwavearcade Just want to confirm if you will still have time to work on this. If not, I can take a look over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants