close
The Wayback Machine - https://web.archive.org/web/20210516020033/https://github.com/apache/shardingsphere/issues/9521
Skip to content

/ shardingsphere

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test cases for ShardingSphereRulesBuilder if implements ResourceAware #9521

Open
terrymanu opened this issue Feb 26, 2021 · 3 comments
Open

Add more test cases for ShardingSphereRulesBuilder if implements ResourceAware #9521

terrymanu opened this issue Feb 26, 2021 · 3 comments
Assignees
@songyuequan
Labels
good first issue in: test
Milestone
5.0.0-beta

Comments

@terrymanu
Copy link
Member

@terrymanu terrymanu commented Feb 26, 2021

No description provided.

@terrymanu terrymanu added this to the 5.0.0-beta milestone Feb 26, 2021
@songyuequan
Copy link

@songyuequan songyuequan commented Mar 1, 2021

can I take it please?
@yu199195
Copy link
Member

@yu199195 yu199195 commented Mar 1, 2021

@songyuequan welcome join us
@songyuequan
Copy link

@songyuequan songyuequan commented Mar 3, 2021

@terrymanu hi~ ShardingSphereRulesBuilder is not the implements of ResourceAware . should I add test cases In ShardingSphereRulesBuilder to test if all of "ShardingSphereRulesBuilder" implement ResourceAware? I feel confused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@songyuequan songyuequan

Labels
good first issue in: test
Projects
None yet
Milestone
5.0.0-beta
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@terrymanu @songyuequan @yu199195