close
The Wayback Machine - https://web.archive.org/web/20210609030410/https://github.com/renovatebot/renovate/issues/8141
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test readability with expect-more-jest #8141

Open
rarkins opened this issue Dec 26, 2020 · 8 comments
Open

Improve test readability with expect-more-jest #8141

rarkins opened this issue Dec 26, 2020 · 8 comments

Comments

@rarkins
Copy link
Collaborator

@rarkins rarkins commented Dec 26, 2020

This package could be used to enhance the readability of a lot of our tests:
https://github.com/JamieMason/expect-more/tree/master/packages/expect-more-jest/

@HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Jan 8, 2021

The expect-more-jest package is still using a unstable 0.x.y release scheme (expect-more@0.8.1).

Shouldn't we wait until expect-more-jest has a stable release before using it?
Or are you OK with devDependencies potentially breaking?


EDIT: Turns out I got the versions mixed up, read my post below for accurate information.

@rarkins rarkins moved this from Ready to Blocked in Renovate Jan 8, 2021
@rarkins
Copy link
Collaborator Author

@rarkins rarkins commented Jan 8, 2021

Good point. Let's mark this as blocked

@HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Jan 8, 2021

Whoops, I'm getting my versions mixed up...

I was looking at the expect-more package, and that's unstable at 0.8.1.
But expect-more-jest is stable at 5.2.1.

I did some more digging, and found that the expect-more-jest package does depend on the expect-more package:
https://github.com/JamieMason/expect-more/blob/master/packages/expect-more-jest/package.json

If we install expect-more-jest right now, we're also getting a unstable version of expect-more with it.
I'll leave you to decide how you want to weigh this, now that the information is actually accurate... 😄

@rarkins rarkins moved this from Blocked to Ready in Renovate Jan 8, 2021
@rarkins
Copy link
Collaborator Author

@rarkins rarkins commented Jan 8, 2021

In theory expect-more-jest should provide a stable API to us, and if the author changes anything underneath it then they will make it transparent to us. I think this tips it in favor of using it.

@JamieMason
Copy link

@JamieMason JamieMason commented Jan 20, 2021

Hey @rarkins @HonkingGoose I just stumbled on this issue, despite the 0.x version I consider expect-more to be stable - it's on 0.x just because I haven't committed a breaking change yet, which would move it to 1.x. I could declare it 1.x to reflect that sentiment, but this is some background incase it's helpful.

Thanks

@rarkins
Copy link
Collaborator Author

@rarkins rarkins commented Jan 20, 2021

@JamieMagee I think semantic versioning is intended that pre-1.0.0 versions are liable to change API at any time (without bumping to 1.0.0) and that anything intended for production should be 1.0.0 or higher. When a dependency is 0.x it means users need to pay close attention to every update just in case it's changed API, as the maintainer is perfectly allowed to do. In short, anything ready for production should be 1.0.0 or later and anyone running things in production should try to avoid pre-1.0.0 packages (easier said than done..)

Anyway it looks like we can move ahead with expect-more regardless, thanks for clarifying.

@JamieMason
Copy link

@JamieMason JamieMason commented Jan 20, 2021

Great, I'll bump it to 1.x when I next work on it too

@JamieMason
Copy link

@JamieMason JamieMason commented Feb 12, 2021

(FYI 1.x bump is done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants