close
The Wayback Machine - https://web.archive.org/web/20210705014320/https://github.com/dmlc/xgboost/issues/6496
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for mypy. #6496

Open
trivialfis opened this issue Dec 13, 2020 · 1 comment
Open

Better support for mypy. #6496

trivialfis opened this issue Dec 13, 2020 · 1 comment

Comments

@trivialfis
Copy link
Member

@trivialfis trivialfis commented Dec 13, 2020

Currently many more Python projects like dask and optuna are using Python type hints. With the Python package of xgboost gaining more and more features, we should also adopt mypy as a safe guard against some type errors and for better code documentation.

@trivialfis
Copy link
Member Author

@trivialfis trivialfis commented Dec 17, 2020

I marked this as good first issue. Adding type checks for Python is an incremental process, parameter by parameter and function by function. It would be a good chance to review existing code base and make improvement during the process. I have made some progress on #6519 with the dask module, which is by far the most dynamic module in xgboost. Other modules can use it as a base line.

Contributions are welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant