close
The Wayback Machine - https://web.archive.org/web/20210318190301/https://github.com/flameshot-org/flameshot/issues/1453
Skip to content

/ flameshot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary "share/*" directories installed on Windows #1453

Open
hosiet opened this issue Mar 11, 2021 · 0 comments
Open

Unnecessary "share/*" directories installed on Windows #1453

hosiet opened this issue Mar 11, 2021 · 0 comments
Labels
Good first issue

Comments

@hosiet
Copy link
Member

@hosiet hosiet commented Mar 11, 2021

Flameshot version
(All versions)

Describe the bug
There are lots of Linux-only files installed when Windows MSI package is installed:

图片

Probably we should add an if() statement in src/CMakeLists.txt file and do not call those configure_file() instructions on Windows/Mac platform.

Expected behavior
Unnecessary files under C:\Program Files\Flameshot\share\ should not exist.

System Information
Any Windows system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@hosiet @borgmanJeremy