close
The Wayback Machine - https://web.archive.org/web/20210720211415/https://github.com/OpenZeppelin/openzeppelin-contracts/issues/890
Skip to content

/ openzeppelin-contracts

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECDSA#toEthSignedMessageHash for bytes type #890

Open
shrugs opened this issue Apr 12, 2018 · 8 comments
Open

Add ECDSA#toEthSignedMessageHash for bytes type #890

shrugs opened this issue Apr 12, 2018 · 8 comments
Labels
good first issue

Comments

@shrugs
Copy link
Contributor

@shrugs shrugs commented Apr 12, 2018 •
edited by frangio

🎉 Description

The ECDSA contract has a function toEthSignedMessage(bytes32), but we should have a function that works for any length of a bytes array:

function toEthSignedMessage(bytes s) pure internal returns (bytes32) {
  return keccak256(
    "\x19Ethereum Signed Message:\n",
    uintToBytes(s.length),
    s);
}

Where uintToBytes is implemented from an ideally MIT-licensed project with appropriate attribution.
@frangio
Copy link
Member

@frangio frangio commented Apr 12, 2018

For uintToBytes we could use pipermerriam/ethereum-string-utils.
@k06a
Copy link
Contributor

@k06a k06a commented Apr 24, 2018

@shrugs usually s is of length 32, because it is hash of the original message. This kind of method will be still very useful:

function ethSignedMessage(bytes32 hash) pure internal returns (bytes32) {
  return keccak256(
    "\x19Ethereum Signed Message:\n32",
    hash);
}
@frangio
Copy link
Member

@frangio frangio commented Apr 24, 2018

https://github.com/OpenZeppelin/zeppelin-solidity/blob/76fe1548aee183dfcc395364f0745fe153a56141/contracts/ECRecovery.sol#L64-L75

😃
@k06a
Copy link
Contributor

@k06a k06a commented Apr 24, 2018

@frangio awesome 😎
@k06a
Copy link
Contributor

@k06a k06a commented Apr 25, 2018

@frangio this code is not yet included in the latest release. I am waiting for it to use in https://github.com/bitclave/Feeless
@frangio frangio changed the title Add ECRecovery#ethSignedMessage for bytes type Add ECDSA#ethSignedMessage for bytes type Jul 13, 2019
@frangio frangio changed the title Add ECDSA#ethSignedMessage for bytes type Add ECDSA#toEthSignedMessageHash for bytes type Jul 13, 2019
@frangio
Copy link
Member

@frangio frangio commented Jul 13, 2019

Update: we already have Strings.fromUint256 for converting numbers to strings.
@nventuro
Copy link
Contributor

@nventuro nventuro commented Jul 17, 2019

Note that signed data should always be a hash, since signatures can be faked for arbitrary data. This helper would still be safe in that sense because, even if the underlying bytes are not a hash, the whole signed message is.
@frev100
Copy link

@frev100 frev100 commented Feb 24, 2021

Thanks :D
@frangio frangio mentioned this issue Mar 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@frangio @k06a @shrugs @nventuro @frev100