Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
add BUILD_WITH_STACK_PROTECTOR option#1756
Merged
kevinbackhouse merged 1 commit intoExiv2:mainfrom Jul 8, 2021
ffontaine:main
Merged
add BUILD_WITH_STACK_PROTECTOR option#1756kevinbackhouse merged 1 commit intoExiv2:mainfrom ffontaine:main
kevinbackhouse merged 1 commit intoExiv2:mainfrom
ffontaine:main
Conversation
Add BUILD_WITH_STACK_PROTECTOR to avoid the following build failure with toolchains that don't support stack-protector: /home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/9.3.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld: utils.cpp:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_M_constructIPcEEvT_S7_St20forward_iterator_tag[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_M_constructIPcEEvT_S7_St20forward_iterator_tag]+0xd0): undefined reference to `__stack_chk_fail' Indeed, support for -fstack-protector-strong can't be detected through check_cxx_compiler_flag as some toolchains need to link with -lssp to enable SSP support Fixes: - http://autobuild.buildroot.org/results/ae4635899124c602c70d2b342a76f95c34aa4a3d Signed-off-by: Fabrice Fontaine <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1756 +/- ##
=======================================
Coverage 67.22% 67.22%
=======================================
Files 151 151
Lines 20787 20787
=======================================
Hits 13975 13975
Misses 6812 6812 Continue to review full report at Codecov.
|
kevinbackhouse
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
BUILD_WITH_STACK_PROTECTORto avoid the following build failure with toolchains that don't support stack-protector:/home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/9.3.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld: utils.cpp:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_M_constructIPcEEvT_S7_St20forward_iterator_tag[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE12_M_constructIPcEEvT_S7_St20forward_iterator_tag]+0xd0): undefined reference to__stack_chk_fail'`Indeed, support for -fstack-protector-strong can't be detected through
check_cxx_compiler_flagas some toolchains need to link with-lsspto enable SSP supportFixes:
Signed-off-by: Fabrice Fontaine [email protected]