Pinned
2,610 contributions in the last year
Less
More
Activity overview
Contributed to
cockroachdb/cockroach,
cockroachdb/cockroach-gen,
cockroachdb/errors
and 5 other
repositories
Contribution activity
July 2021
Created 102 commits in 3 repositories
Created 1 repository
- knz/buf Go
Created a pull request in cockroachdb/cockroach that received 12 comments
cli: move the demo cluster to new sub-package democluster (5/)
First 15 commits are from #67459 and prior. Please ignore those (they will disappear once the prefix PR is merged) Only the last 5 commits belong t…
+4,409
−2,888
•
12
comments
Opened 20 other pull requests in 3 repositories
cockroachdb/cockroach
3
open
13
merged
2
closed
-
clisqlexec: remove the
treedependency - clisqlclient: trim down dependencies
- clisqlclient: drop the dependency on 'security'
-
cli: new sub-package
clisqlcfgto ease the creation of a standalone SQL shell (8/) - cmd/cockroach-sql: new standalone SQL shell
-
cli: new sub-package
clisqlcfgto ease the creation of a standalone SQL shell (8/) -
cli: lift the SQL shell into its own sub-package
clisqlshell(7/) - cli: SQL shell cleanups and better encapsulation (6/)
-
cli: new sub-package
clisqlexecfor the execution/formatting code (4/) -
cli: some cleanups to the new package
clisqlclient(3/) -
cli: extract the SQL connection code to a new package
clisqlclient(2/) - cli: extract the value formatting code to a sub-package (1/)
- cli: don't interleave warnings with statement timings
-
cli/debug: clean up handling of
--formatfordebug tsdump - Revert/redo "deps: update bufbuild/buf"
- cli: various refactors
- deps: update bufbuild/buf
- deps: update bufbuild/buf
bufbuild/buf
1
closed
cockroachdb/redact
1
merged
Reviewed 22 pull requests in 2 repositories
cockroachdb/cockroach 20 pull requests
- server: re-load cluster settings on each engine checker loop
- parser: move scan.go to new scanner package
- builtins: add crdb_internal.read/write_file
- clisqlclient: trim down dependencies
-
cli: lift the SQL shell into its own sub-package
clisqlshell(7/) - cli: SQL shell cleanups and better encapsulation (6/)
-
cli: move the demo cluster to new sub-package
democluster(5/) -
cli: extract the SQL connection code to a new package
clisqlclient(2/) - parser: reduce imports for scan.go
-
cli: some cleanups to the new package
clisqlclient(3/) - sql/pgwire: implement pgwire query cancellation
- log: create crdb-v2 log entry parser and integrate it into debug merge-logs
- server: require admin role to access node status
- sql: add partial redactability to logs
- sql: cache hashed password and auth info during authentication
- envutil,server: report more env vars upon server startup and in telemetry
-
clusterversion: set
binaryMinSupportedVersiontov21_1 - backupccl: fully qualify table names for scheduled BACKUPs
- release-21.1: sqlliveness/slstorage: break InternalExecutor depedency
- kv: implement SafeFormatter for Table/Tenant roachpb.Key
cockroachdb/docs 2 pull requests
Created an issue in cockroachdb/cockroach that received 20 comments
build: cockroachdb build is broken on master
cc @bufdev @dt
I can't build CockroachDB any more since #66913 went in.
github.com/bufbuild/buf/internal/pkg/interrupt
# github.com/bufbuild/buf/in…
20
comments
Opened 16 other issues in 2 repositories
cockroachdb/cockroach
9
open
6
closed
- logictestccl: the test target often times out at 30 minutes, while the median run time is well below 30 minutes
- kvserver: failure in TestStoreRangeMergeWatcher
- roachtest: bazel CI fails, while github CI succeeds
- streamclient: panic in TestIdleExit
-
break the dependency on
treein the SQL formatter (tree.Nameandtree.DString) by using the underlying functions fromlex - clisqlexec: trim down dependencies
- clisqlclient: trim down dependencies
-
extract
security.PromptForPassword()into a lightweight dependency package and use that instead ofsecurity - backupccl: test flakes in the Bazel-CI target, probably due to timeout
- build: build-time tooling go dependencies mistakenly mixed with run-time go dependencies
- cli/sql: trim down the deps of the SQL shell to achieve a binary smaller than 10MiB
-
cli: support the
NO_COLORenv var -
cli: the
statement-diagcommand doesn't clean up properly -
cli:
debug tsdumpmisuses the--formatflag -
unique bazel CI failure with a test timeout in
colexec

