close
The Wayback Machine - https://web.archive.org/web/20201130142834/https://github.com/wovalle/fireorm/issues/54
Skip to content

/ fireorm

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create OrderBy and Limit integration tests #54

Open
wovalle opened this issue Jun 17, 2019 · 4 comments
Open

Create OrderBy and Limit integration tests #54

wovalle opened this issue Jun 17, 2019 · 4 comments
Labels
good first issue help wanted prio
Milestone
v1

Comments

@wovalle
Copy link
Owner

@wovalle wovalle commented Jun 17, 2019 •
edited

Problem

As soon as features are added, we should provide examples on how to use them to help people using fireorm for the first time.

Acceptance Criteria

  • A new example should be added to /examples implementing OrderBy and Limit
  • README is updated with the new example
@wovalle wovalle added this to the v1 milestone Jun 27, 2019
@jonesnc
Copy link
Contributor

@jonesnc jonesnc commented Jul 9, 2019

@wovalle I'm working on this one (unless someone else already is).
@wovalle
Copy link
Owner Author

@wovalle wovalle commented Jul 10, 2019

Thanks @jonesnc! Nobody is working on this as far as I know 😄
@wovalle wovalle mentioned this issue Jul 12, 2019
Merged
5 of 5 tasks complete
@jonesnc
Copy link
Contributor

@jonesnc jonesnc commented Jul 15, 2019 •
edited

@wovalle Since #72 repurposes the examples, I think I'll just start writing example usage of orderBy and limit and add it to the README and call it good.
@wovalle
Copy link
Owner Author

@wovalle wovalle commented Jul 16, 2019

Yeah we can do that. I'll also create a integration tests for those.
@wovalle wovalle added the prio label Oct 9, 2019
@wovalle wovalle changed the title Create examples of OrderBy and Limit Create OrderBy and Limit integration tests Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted prio
Projects
None yet
Milestone
v1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jonesnc @wovalle
You can’t perform that action at this time.