close
The Wayback Machine - https://web.archive.org/web/20210605235615/https://github.com/searx/searx/issues/2263
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger image previews #2263

Open
RandomClaim opened this issue Oct 15, 2020 · 4 comments
Open

Bigger image previews #2263

RandomClaim opened this issue Oct 15, 2020 · 4 comments

Comments

@RandomClaim
Copy link

@RandomClaim RandomClaim commented Oct 15, 2020

Currently when clicking an image from search resutls the pop-up includes the image at a fixed size.
I propose to either increase that scaling to a somewhat higher fixed value or factor in the original image size so that very small pictures do not become pixelated.

Currently the preview is too small in my opinion which forces me to visit the website.

@a22a-dev
Copy link

@a22a-dev a22a-dev commented Oct 24, 2020

Yup! Came all the way here to just mention this. Please look into this problem.

@xnghu
Copy link

@xnghu xnghu commented Nov 17, 2020

i agree. also as a suggested future feature, the ability to filter image results by size or file type would be absolutely wonderful!!

in the meantime, i will slowing be studying the code, as perhaps eventually i will know how to help contribute to the project to make such things a possibility! :P

@unixfox
Copy link
Member

@unixfox unixfox commented Nov 18, 2020

i agree. also as a suggested future feature, the ability to filter image results by size or file type would be absolutely wonderful!!

Feel free to open another issue for that :).

in the meantime, i will slowing be studying the code, as perhaps eventually i will know how to help contribute to t

This issue is most likely only Javascript oriented because it's related to the frontend so if you are good in js then you will probably be able to write some code for that.

@dalf
Copy link
Contributor

@dalf dalf commented Nov 18, 2020

searx and a browser see two different versions of a same search engine:

  • with a browser and javascript enabled, you get all the features. The browser can make an additional HTTP request to display a full screen version of the image.
  • without javascript, searx see a simplified version, and can make one or few HTTP requests (to keep the response time low, and to stay stateless). Often the no-javascript version get less care from the different search engines.

Here an example of an google image result without javascript (see https://support.mozilla.org/en-US/questions/994809 ) :
google image

If you click on one image, you go directly to the website. Some images are base64 encoded.

This is what searx sees.

bing image seems to be broken without javascript inside a browser, but searx manages to get the results.

So most probably and unfortunately, it is difficult to get bigger image previews.

Most probably, because may be for some image search engines, there are some tricks to get the full size image URL with no / few HTTP request(s). As usual for the engines: it requires a careful analysis, and maintenance over time (since a search engine can update its web site any time without notice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants