close
The Wayback Machine - https://web.archive.org/web/20210731035112/https://github.com/KaTeX/KaTeX/issues/2707
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use toThrowErrorMatchingInlineSnapshot in unit tests #2707

Open
kevinbarabash opened this issue Dec 27, 2020 · 1 comment
Open

Comments

@kevinbarabash
Copy link
Member

@kevinbarabash kevinbarabash commented Dec 27, 2020

We currently use .not.toParse() which doesn't actually provide any information about what the failure mode is. Switching to toThrowErrorMatchingInlineSnapshot() shouldn't be too much work. It's probably something that could be done with a find-and-replace regex followed by running jest with the -u to update all of the snapshots.

docs: https://jestjs.io/docs/en/expect#tothrowerrormatchinginlinesnapshotinlinesnapshot

@3r3n-n
Copy link

@3r3n-n 3r3n-n commented Jun 9, 2021

Hi !
Can I try to work on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants