close
The Wayback Machine - https://web.archive.org/web/20200914174836/https://github.com/jenkinsci/jenkinsfile-runner/issues/261
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Jenkinsfile Runner versions in demos #261

Open
oleg-nenashev opened this issue Apr 2, 2020 · 1 comment
Open

Pin Jenkinsfile Runner versions in demos #261

oleg-nenashev opened this issue Apr 2, 2020 · 1 comment

Comments

@oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Apr 2, 2020

Currently Jenkinsfile Runner demos use the runner version from the local repository. So each demo basically needs an update every time an incompatible version is released. It would be better to support delaying the demo updates by using an explicit Jenkinsfile Runner version definitions in all Custom War Packager config files

@oleg-nenashev oleg-nenashev added the demo label Apr 2, 2020
@sladyn98
Copy link
Contributor

@sladyn98 sladyn98 commented Apr 5, 2020

+1 to this change, but that would mean manually pinning every jenkinsfile runner demo, or we would just pin it here and then the resultant demos will then pick it up .
https://github.com/jenkinsci/custom-war-packager/blob/3aa29ed5432051198b9de410223732cc21843f36/demo/jenkinsfile-runner/Makefile#L5 --> This version seems to be fixed, am I missing something here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.