close
The Wayback Machine - https://web.archive.org/web/20210803221717/https://github.com/microsoft/vcpkg/pull/16758
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Rename docs/index.md to docs/README.md #16758

Merged
merged 2 commits into from Mar 18, 2021

Conversation

@autoantwort
Copy link
Contributor

@autoantwort autoantwort commented Mar 18, 2021

When I search for documentation, I open the docs folder in github, but then I don't see the topics of the help pages. I first have to open the index.md file. With this change I directly see the content of the index.md file without opening it.
See here for reference.

@PhoebeHui PhoebeHui changed the title Rename docs/index.md to docs/README.md [docs] Rename docs/index.md to docs/README.md Mar 18, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

LGTM, thanks for the PR!

@ras0219-msft
Copy link
Contributor

@ras0219-msft ras0219-msft commented Mar 18, 2021

We name the file index.md for compatibility with MkDocs (https://www.mkdocs.org/); to rename this we would need to also add a mkdocs config file.

@autoantwort
Copy link
Contributor Author

@autoantwort autoantwort commented Mar 18, 2021

We name the file index.md for compatibility with MkDocs (https://www.mkdocs.org/); to rename this we would need to also add a mkdocs config file.

I don't think so. From here:

Many repository hosting sites provide special treatment for README files by displaying the contents of the README file when browsing the contents of a directory. Therefore, MkDocs will allow you to name your index pages as README.md instead of index.md. In that way, when users are browsing your source code, the repository host can display the index page of that directory as it is a README file. However, when MkDocs renders your site, the file will be renamed to index.html so that the server will serve it as a proper index file.

If both an index.md file and a README.md file are found in the same directory, then the index.md file is used and the README.md file is ignored.

If I understand correctly, you can name the file index.md or README.md

@ras0219-msft ras0219-msft merged commit 20fad53 into microsoft:master Mar 18, 2021
12 checks passed
12 checks passed
@microsoft-cla
license/cla All CLA requirements met.
Details
@azure-pipelines
microsoft.vcpkg.pr Build #20210318.4 succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Formatting and Documentation Checks Job) Formatting and Documentation Checks Job succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: arm64_windows) Run PR Tests: arm64_windows succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: arm_uwp) Run PR Tests: arm_uwp succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: x64_linux) Run PR Tests: x64_linux succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: x64_osx) Run PR Tests: x64_osx succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: x64_uwp) Run PR Tests: x64_uwp succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: x64_windows) Run PR Tests: x64_windows succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: x64_windows_static) Run PR Tests: x64_windows_static succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: x64_windows_static_md) Run PR Tests: x64_windows_static_md succeeded
Details
@azure-pipelines
microsoft.vcpkg.pr (Run PR Tests: x86_windows) Run PR Tests: x86_windows succeeded
Details
@ras0219-msft
Copy link
Contributor

@ras0219-msft ras0219-msft commented Mar 18, 2021

Awesome, just a reading comprehension fail on my part. Thanks!

mathisloge pushed a commit to mathisloge/vcpkg that referenced this pull request Jul 6, 2021
* Rename docs/index.md to docs/README.md

* Update links to index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants