close
The Wayback Machine - https://web.archive.org/web/20210807110719/https://github.com/testjavascript/nodejs-integration-tests-best-practices/issues/30
Skip to content

/ nodejs-integration-tests-best-practices

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich our DB model #30

Open
goldbergyoni opened this issue Dec 8, 2020 · 1 comment
Open

Enrich our DB model #30

goldbergyoni opened this issue Dec 8, 2020 · 1 comment
Assignees
@DanielGluskin
Labels
for-release good first issue

Comments

@goldbergyoni
Copy link
Contributor

@goldbergyoni goldbergyoni commented Dec 8, 2020

The example app DB schema is too simplistic and might not tell the truth when conducting performance benchmarks. It could be great to add a few more fields to the main table and also one more relation.

Before picking this issue, it's recommended to have a short tech planning chat here and only then upon sync to get up to speed.
@goldbergyoni
Copy link
Contributor Author

@goldbergyoni goldbergyoni commented Feb 5, 2021

There are levels of data that we should have:

  • Test data - Orders - Rows that are modified by the tests - Created per test - We have this
  • Context - StoreInfo - Rows that are related to the test but not modified by the test - Created per suite - We need this
  • Metadata - Countries - Rows that just serve as global enums and supporting data - Created once - We need this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielGluskin DanielGluskin

Labels
for-release good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@goldbergyoni @DanielGluskin