close
The Wayback Machine - https://web.archive.org/web/20210908155246/https://github.com/flutter/plugins/pull/3723
Skip to content

/ plugins Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integration_test] Deprecate, and stop using in this repository #3723

Merged
merged 4 commits into from Mar 19, 2021
Merged

[integration_test] Deprecate, and stop using in this repository #3723

merged 4 commits into from Mar 19, 2021

Conversation

@stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Mar 17, 2021

  • Updates integration_test README to note that the published version is deprecated and direct people to the SDK version.
  • Updates all plugins here to use the SDK version.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.
@stuartmorgan
Update the package to indicate that it's deprecated
280f12b
@stuartmorgan
Update repo md files
83412ba
@stuartmorgan
Update all plugins to reference SDK copy
71d2030
@stuartmorgan
Remove package reference from CONTRIBUTING.md
9eadbbc
@google-cla google-cla bot added the cla: yes label Mar 17, 2021
@stuartmorgan
Copy link
Contributor Author

@stuartmorgan stuartmorgan commented Mar 17, 2021

This doesn't update the version and CHANGELOG of all the plugins it touches since I would not expect this to be a change that matters in the published version, thus shouldn't need publishing. If there's a reason we need to publish that I missed, I can update the PR accordingly.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
4d5c35e 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
0e5ac9c 
…ry (flutter/plugins#3723)
@ditman
Copy link
Member

@ditman ditman commented Mar 19, 2021

At some point, we need to ask people to unpublish this, maybe? https://pub.dev/packages/integration_test Or mark it as "deprecated"?

@stuartmorgan
Copy link
Contributor Author

@stuartmorgan stuartmorgan commented Mar 19, 2021

Yes, I was going to publish this now to guide people via the README, then eventually (I need to think about how long to wait) mark it as discontinued.

@ditman
Copy link
Member

@ditman ditman commented Mar 19, 2021

@stuartmorgan I've seen that pub.dev redirects to the flutter API docs for some packages. I'm not sure how that's achieved, but check out this link: http://pub.dev/packages/flutter_test. It'd be nice that integration_test eventually redirected to api.flutter.dev as well!

@stuartmorgan
Copy link
Contributor Author

@stuartmorgan stuartmorgan commented Mar 19, 2021

Oh, that's nice! @jonasfj what's the mechanism for adding a redirect like that?

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
b8d74cc 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
d4a9328 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
1bf7e4f 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
955abf4 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
e9f7bd5 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
982537d 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
535ba76 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
1da4ca1 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
f0db0ec 
…ry (flutter/plugins#3723)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
15d4f9c [integration_test] Deprecate, and stop using in this reposito…
7f82793 
…ry (flutter/plugins#3723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman

@mvanbeusekom mvanbeusekom

@bparrishMines bparrishMines

@cyanglaz cyanglaz

@dnfield dnfield

@LHLL LHLL

Assignees
No one assigned
Labels
cla: yes p: android_alarm_manager p: android_intent p: battery p: camera p: connectivity p: device_info p: flutter_plugin_android_lifecycle p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: integration_test p: local_auth p: package_info p: path_provider p: quick_actions p: sensors p: share p: shared_preferences p: url_launcher p: video_player p: webview_flutter p: wifi_info_flutter platform-linux platform-macos platform-windows
Projects
None yet
Milestone
No milestone
3 participants
@stuartmorgan @mvanbeusekom @ditman