Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
chore(types): fix types to use not @types/selenium-webdriver #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the USE_PROMISE_MANAGER test in spec/ts/basic - Remove the check if we are using the control flow or not
cnishina
force-pushed
the
selenium_webdriver_typings
branch
from
62a5ad3
to
428852a
Compare
heathkit
approved these changes
Jan 25, 2019
CrispusDH
reviewed
Jan 25, 2019
| @@ -882,7 +860,7 @@ export class ProtractorBrowser extends AbstractExtendedWebDriver { | |||
| * await browser.get('http://angular.github.io/protractor/#/tutorial'); | |||
| * await browser.setLocation('api'); | |||
| * expect(await browser.getCurrentUrl()) | |||
| * .toBe('http://angular.github.io/protractor/#/api'); | |||
| * .toBe('http://angular.g../../ithub.io/protractor/#/api'); | |||
cnishina
added a commit
to cnishina/protractor
that referenced
this issue
Mar 23, 2019
…#5127) - Remove the USE_PROMISE_MANAGER test in spec/ts/basic - Remove the check if we are using the control flow or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.