close
The Wayback Machine - https://web.archive.org/web/20201211173151/https://github.com/cookpete/react-player/pull/1044
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Audius.co embeds #1044

Open
wants to merge 5 commits into
base: master
from

Conversation

@brycedev
Copy link

@brycedev brycedev commented Oct 11, 2020

Audius.co is a newer, high quality streaming service.

This pull request adds support for Audius embeds like so <ReactPlayer url='https://audius.co/embed/track?id=88754&ownerId=275&flavor=card' />

Tests have been included. Thank you in advance for your consideration.

@cookpete
Copy link
Owner

@cookpete cookpete commented Nov 14, 2020

I'm normally apprehensive about adding bytes to the package that won't be used, but:

  • it looks like a cool platform
  • people can use lazy players
  • I'm planning a rewrite that should cut the bundle size down
  • you clearly put a lot of effort into this

So I would be up for adding this. However, it seems to be broken? https://audius.co/embed/api.js returns a 404 for me, and I can't find any docs about the player API.

@brycedev
Copy link
Author

@brycedev brycedev commented Nov 23, 2020

Thank you so much for getting back with me! I'm glad you're ultimately interested in getting it integrated.
From my understanding there was scheduled maintenance around the time you tested that embed link. It should be available now.

Also, there is no embed api documentation yet, but I will make submit a PR for the documentation. It is extremely similar to Soundcloud's Widget API, if that is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.