close
The Wayback Machine - https://web.archive.org/web/20201002123022/https://github.com/algolia/scout-extended/issues/192
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty searchable array is indexed with only meta data. #192

Open
wisoot opened this issue Jun 27, 2019 · 2 comments
Open

Empty searchable array is indexed with only meta data. #192

wisoot opened this issue Jun 27, 2019 · 2 comments

Comments

@wisoot
Copy link
Contributor

@wisoot wisoot commented Jun 27, 2019

Similar to the bug report in scout here: #350 - if meta data is not empty due to the setting to switch on soft_delete in scout.config.soft_delete.

In this line here: https://github.com/algolia/scout-extended/blob/v1.6.0/src/Jobs/UpdateJob.php#L109 checking on emptiness of searchable array should be perform separately from metadata as it will always be fault when soft_delete is enabled.

@nunomaduro
Copy link
Contributor

@nunomaduro nunomaduro commented Jun 27, 2019

@wisoot Do you think that you are able to do a pull request with tests on this?

@wisoot
Copy link
Contributor Author

@wisoot wisoot commented Jul 3, 2019

@nunomaduro Here is the PR: #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.