close
The Wayback Machine - https://web.archive.org/web/20201228093601/https://github.com/magda-io/magda/issues/1462
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide map preview if we get a mixed-content error #1462

Open
aneesha09 opened this issue Jul 17, 2018 · 3 comments
Open

Hide map preview if we get a mixed-content error #1462

aneesha09 opened this issue Jul 17, 2018 · 3 comments

Comments

@aneesha09
Copy link

@aneesha09 aneesha09 commented Jul 17, 2018

Problem description

Map is not loading for the data set -
https://dev.magda.io/dataset/ds-aims-6f61137b-8baa-40fa-bde1-670655254afa/details?q=csiro

seabed_biodiversity_on_the_continental_shelf_of_the_great_barrier_reef_world_heritage_area_2003_-_2006__crc_reef__csiro__data_gov_au

Also merging - #1344

If you go to this dataset: https://dev.magda.io/dataset/ds-nsw-d5874805-6397-414b-a53b-1ee5537b761d/details?q=greater%20sydney%20water%20supply (Greater Sydney Water Supply), the TerriaMap isn't able to download the underlying data because it's loaded via HTTP (not HTTPS) from a .com.au address. This is usual, but we should have detected that and stopped the map from loading.

Problem reproduction steps
Go to https://dev.magda.io/dataset/ds-nsw-d5874805-6397-414b-a53b-1ee5537b761d/details?q=greater%20sydney%20water%20supply and watch the map.

Problem reproduction steps

Screenshot / Design / File reference

@AlexGilleran AlexGilleran changed the title Map is not loading for data set Show error message for mixed-content error in map preview Jul 17, 2018
@AlexGilleran
Copy link
Member

@AlexGilleran AlexGilleran commented Jul 17, 2018

This is happening because of

CatalogGroup.js:6 Mixed Content: The page at 'https://dev.magda.io/dataset/ds-aims-6f61137b-8baa-40fa-bde1-670655254afa/details?q=csiro' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://maps.eatlas.org.au/geoserver/wms?service=WMS&request=GetCapabilities&version=1.3.0&tiled=true'. This request has been blocked; the content must be served over HTTPS.

maps.eatlas.org.au isn't on the list of domains that terria wants to proxy, so it fails. This causes the map to load forever.

@tkeuneman @philipgrimmett do you think we should hide the map in this case or show an error message?

@tkeuneman
Copy link
Contributor

@tkeuneman tkeuneman commented Jul 17, 2018

Hide it

@AlexGilleran AlexGilleran changed the title Show error message for mixed-content error in map preview Hide map preview if we get a mixed-content error Jul 17, 2018
@aneesha09 aneesha09 added this to the Sprint 14: Opening Up milestone Jul 17, 2018
@tkeuneman tkeuneman removed this from the Sprint 14: Opening Up milestone Jul 18, 2018
@aneesha09 aneesha09 added this to the Sprint 15 milestone Jul 25, 2018
@chloeleichen chloeleichen self-assigned this Jul 26, 2018
@aneesha09 aneesha09 removed this from the Sprint 15 milestone Jul 31, 2018
@aneesha09
Copy link
Author

@aneesha09 aneesha09 commented Aug 10, 2018

Hey @chloeleichen - Could you kindly look at this next week?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.