close
The Wayback Machine - https://web.archive.org/web/20210916151817/https://github.com/angular/components/pull/18042
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed minor typos and table formatting #18042

Merged
merged 1 commit into from Dec 29, 2019

Conversation

@TheVikash
Copy link
Contributor

@TheVikash TheVikash commented Dec 26, 2019

  • fixed minor typos in FAQ.md, Readme.md, icon.md file
  • fixed table formatting in card.md
@TheVikash TheVikash requested review from jelbourn and as code owners Dec 26, 2019
@googlebot
Copy link

@googlebot googlebot commented Dec 26, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@TheVikash
Copy link
Contributor Author

@TheVikash TheVikash commented Dec 26, 2019

@googlebot I fixed it.

2 similar comments
@TheVikash
Copy link
Contributor Author

@TheVikash TheVikash commented Dec 26, 2019

@googlebot I fixed it.

@TheVikash
Copy link
Contributor Author

@TheVikash TheVikash commented Dec 26, 2019

@googlebot I fixed it.

@googlebot
Copy link

@googlebot googlebot commented Dec 26, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@crisbeto crisbeto left a comment

LGTM

@mmalerba mmalerba merged commit 4dd0873 into angular:master Dec 29, 2019
11 of 12 checks passed
11 of 12 checks passed
@ngbot[bot]
ci/angular: merge status Missing required labels: target: *
Image
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
Image
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
Image
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
Image
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
Image
ci/circleci: lint Your tests passed on CircleCI!
Details
Image
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
Image
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
Image
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
Image
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
Image
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
@googlebot
cla/google All necessary CLAs are signed
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jan 29, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants