close
The Wayback Machine - https://web.archive.org/web/20211003052017/https://github.com/apple/swift/pull/39556
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use the same TLS context as the runtime for back-deployed concurrency #39556

Merged

Conversation

@DougGregor
Copy link
Member

@DougGregor DougGregor commented Oct 2, 2021

The exclusivity checking support for concurrency relies on having access
to the thread-local set of active memory accesses. Teach the
back-deployed concurrency library to use the same TLS context as the
runtime, which fortunately hasn't change. This fixes the
concurrency exclusivity-checking test in back-deployed configurations
that's tracked by rdar://83064974.

…urrency

The exclusivity checking support for concurrency relies on having access
to the thread-local set of active memory accesses. Teach the
back-deployed concurrency library to use the same TLS context as the
runtime, which fortunately hasn't change. This fixes the
concurrency exclusivity-checking test in back-deployed configurations
that's tracked by rdar://83064974.
@DougGregor
Copy link
Member Author

@DougGregor DougGregor commented Oct 2, 2021

@swift-ci please test

@DougGregor
Copy link
Member Author

@DougGregor DougGregor commented Oct 2, 2021

Verified the change locally on an older system as well.

@DougGregor DougGregor merged commit 20f9aff into apple:main Oct 2, 2021
4 of 5 checks passed
@DougGregor DougGregor deleted the back-deploy-concurrency-memory-exclusivity branch Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant