close
The Wayback Machine - https://web.archive.org/web/20211008061437/https://github.com/amzn/style-dictionary/issues/281
Skip to content

/ style-dictionary Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSDoc param names to match argument names #281

Open
dbanksdesign opened this issue May 28, 2019 · 3 comments
Open

Update JSDoc param names to match argument names #281

dbanksdesign opened this issue May 28, 2019 · 3 comments
Labels
good first issue hacktoberfest help wanted refactor

Comments

@dbanksdesign
Copy link
Member

@dbanksdesign dbanksdesign commented May 28, 2019

In most of our documented functions the argument name(s) don't match the JSDoc param name(s). For example:

https://github.com/amzn/style-dictionary/blob/master/lib/extend.js#L63

JSDoc param name: 'config'
Argument name: 'opts'
@chazzmoney
Copy link
Member

@chazzmoney chazzmoney commented Jun 16, 2019

🤣 I love that we haven't noticed this until now. 🙄

@dbanksdesign dbanksdesign mentioned this issue Jun 17, 2019
Closed
@jamieshark
Copy link

@jamieshark jamieshark commented Jun 21, 2019 •
edited

@dbanksdesign - I can try to handle this!

In files like action.js and filter.js, should we match the options arg or the action param?

@dbanksdesign
Copy link
Member Author

@dbanksdesign dbanksdesign commented Jun 21, 2019

I would say action param because it is unique and specific to the method. Using general names like options or args is not very semantic. But I'm open to opinions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest help wanted refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@dbanksdesign @chazzmoney @jamieshark