close
The Wayback Machine - https://web.archive.org/web/20221225132406/https://github.com/common-workflow-language/cwl-v1.2/pull/123
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify $() and ${} #123

Merged

Conversation

kinow
Copy link
Member

@kinow kinow commented Sep 30, 2021

Fixes common-workflow-language/common-workflow-language#206

Supersedes common-workflow-language/common-workflow-language#929

Quoting the superseded PR:

Hi,

Having a go at the Barn Raising issue about ES expression and ES function body. At first I wrote a longer version with an example $(new Date()) for expression, and a longer ${var dt = new Date(); dt.setDate(dt.getDate() - 2); return dt} function body that returns a date minus 2 days.

But I think it became too specific and made the section even longer? I also thought that perhaps the comparison could go into a NOTE section, but didn't find any such section nearby, so went with the simpler approach.

Happy to amend as per feedback 👍

Thanks
Bruno

p.s.: this PR also fixes a typo, "EMACScript" where it should be "ECMAScript".

mr-c
mr-c approved these changes Oct 6, 2021
@mr-c mr-c merged commit 60ca1e4 into common-workflow-language:1.2.1_proposed Oct 6, 2021
3 checks passed
@kinow kinow deleted the es-expression-function branch Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants