close
The Wayback Machine - https://web.archive.org/web/20220204211227/https://github.com/docsifyjs/docsify/pull/1651
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add nameLink for change logo redirected. #1651

Merged
merged 3 commits into from Oct 15, 2021
Merged

Conversation

@2jun0
Copy link
Contributor

@2jun0 2jun0 commented Oct 14, 2021

Summary

I added nameLink in docs/index.html, To change the sidebar logo link according to the language.

image

What kind of change does this PR introduce?

added nameLink in docs/index.html

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE
@project-bot project-bot bot added this to Needs Review in Triage Oct 14, 2021
@vercel
Copy link

@vercel vercel bot commented Oct 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/4m5A112aajbfXGGtUgFz76YNrgZh
Preview: https://docsify-preview-git-fork-2jun0-develop-docsify-core.vercel.app

@2jun0 2jun0 changed the title Update index.html Added nameLink in docs/index.html Oct 14, 2021
@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 84c12e1:

Sandbox Source
docsify-template Configuration

Copy link
Member

@sy-records sy-records left a comment

Thanks for your contribution. 👍🏻

image

@sy-records sy-records requested a review from Oct 15, 2021
@Koooooo-7 Koooooo-7 changed the title Added nameLink in docs/index.html docs: add nameLink for change logo redirected. Oct 15, 2021
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

LGTM.
thx.

@Koooooo-7 Koooooo-7 merged commit a5cf85b into docsifyjs:develop Oct 15, 2021
12 checks passed
2jun0 added a commit to 2jun0/docsify that referenced this issue Oct 15, 2021
Following this commit, we should also modify the document page.
[docsifyjs#1651](docsifyjs#1651)
2jun0 added a commit to 2jun0/docsify that referenced this issue Oct 15, 2021
Like [this commit](docsifyjs#1651), thie configuration.md page needs to be updated.
sy-records added a commit that referenced this issue Oct 22, 2021
Like [this commit](#1651), thie configuration.md page needs to be updated.

Co-authored-by: 沈唁 <[email protected]>
@Koooooo-7 Koooooo-7 mentioned this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Triage
  
Needs Review
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants