close
The Wayback Machine - https://web.archive.org/web/20210925195707/https://github.com/nunomaduro/phpinsights/issues/376
Skip to content

/ phpinsights Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Laravel] Allow to set command parameters from config file #376

Open
eusonlito opened this issue Mar 10, 2020 · 3 comments
Open

[Laravel] Allow to set command parameters from config file #376

eusonlito opened this issue Mar 10, 2020 · 3 comments
Labels
enhancement good first issue

Comments

@eusonlito
Copy link

@eusonlito eusonlito commented Mar 10, 2020

Q A
Bug report? no
Feature request? yes
Library version 1.13.0

Related with #23 will be a great idea to allow set all commands parameters from config/insights.php when is used with php artisan insights.

Maybe something like:

'parameters' => '--format=json -d memory_limit=2000M -v',

or

'parameters' => [
    '--format=json',
    '-d memory_limit=2000M',
    '-v',
],

Parameters from command line must overwrite config parameters:

php artisan insights --format=html

And also an option to avoid use config will be great:

php artisan insights --no-config-parameters

Thanks!
@eusonlito eusonlito mentioned this issue Mar 10, 2020
Closed
@olivernybroe
Copy link
Collaborator

@olivernybroe olivernybroe commented Mar 10, 2020

Hmm, I think passing it like that would be easy, but also quite limiting.
For example the -d memory_limit=2000M wouldn't work, as that has to be supplied before the file.

It might be worth doing something like this
Carbonize 2020-03-10 at 10 09 51
as that is also what we have done with other parameters.

@eusonlito
Copy link
Author

@eusonlito eusonlito commented Mar 10, 2020 •
edited

Would be great, but my idea is set the parameters on config file as similar as console to avoid to users to know how to map console parameters on config file and to avoid to phpinsights developers create new docs with parameters to config map and code conversions.

But, for me, it's great :)

@quintenbuis quintenbuis mentioned this issue Oct 23, 2020
Closed
@quintenbuis
Copy link

@quintenbuis quintenbuis commented Oct 23, 2020

I've added the requested feature in #441 . If there needs to be added more config options please put it in the PR! 😄

@Jibbarth Jibbarth linked a pull request that will close this issue Oct 24, 2020
Added format as option to config #441
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Added format as option to config
3 participants
@eusonlito @olivernybroe @quintenbuis