close
The Wayback Machine - https://web.archive.org/web/20220419135510/https://github.com/ory/hydra/pull/2831
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add list of authors #2831

Merged
merged 3 commits into from Nov 16, 2021
Merged

feat: add list of authors #2831

merged 3 commits into from Nov 16, 2021

Conversation

grantzvolsky
Copy link
Contributor

@grantzvolsky grantzvolsky commented Oct 31, 2021

The AUTHORS file is now generated upon running make format, make authors.

Resolves #2829

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@grantzvolsky
feat: add list of authors
2c462fc 
The AUTHORS file is now generated upon running `make format`, `make authors`.

Resolves ory#2829
aeneasr
aeneasr previously approved these changes Nov 1, 2021
View changes
@grantzvolsky grantzvolsky marked this pull request as ready for review Nov 1, 2021
@codecov
Copy link

@codecov codecov bot commented Nov 2, 2021 •
edited

Codecov Report

Merging #2831 (c427894) into master (7da8adf) will decrease coverage by 2.97%.
The diff coverage is 8.25%.

❗ Current head c427894 differs from pull request most recent head 5f68261. Consider uploading reports for the commit 5f68261 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2831      +/-   ##
==========================================
- Coverage   52.85%   49.87%   -2.98%     
==========================================
  Files         236      236              
  Lines       14184    14973     +789     
==========================================
- Hits         7497     7468      -29     
- Misses       6054     6843     +789     
- Partials      633      662      +29
Impacted Files Coverage Δ
.../client/admin/accept_consent_request_parameters.go 35.71% <0.00%> (-1.79%) ⬇️
...t/client/admin/accept_consent_request_responses.go 19.23% <0.00%> (ø)
...nt/client/admin/accept_login_request_parameters.go 35.71% <0.00%> (-1.79%) ⬇️
...ent/client/admin/accept_login_request_responses.go 23.80% <0.00%> (ø)
...t/client/admin/accept_logout_request_parameters.go 29.16% <0.00%> (-2.09%) ⬇️
...nt/client/admin/accept_logout_request_responses.go 19.23% <0.00%> (ø)
...client/admin/create_json_web_key_set_parameters.go 32.07% <0.00%> (-1.89%) ⬇️
.../client/admin/create_json_web_key_set_responses.go 14.70% <0.00%> (ø)
...t/client/admin/create_o_auth2_client_parameters.go 26.08% <0.00%> (-2.18%) ⬇️
...nt/client/admin/create_o_auth2_client_responses.go 14.70% <0.00%> (ø)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f6187...5f68261. Read the comment docs.

@aeneasr
Copy link
Member

@aeneasr aeneasr commented Nov 4, 2021

Can we rename "authors" to "contributors"? Thanks!

@mitar
Copy link
Contributor

@mitar mitar commented Nov 16, 2021

There are so many duplicates because people use different e-mail addresses. :-(

@aeneasr aeneasr merged commit 511a668 into ory:master Nov 16, 2021
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add list of authors from git commit to an author file including name and email address
3 participants
@grantzvolsky @aeneasr @mitar