close
The Wayback Machine - https://web.archive.org/web/20220222201539/https://github.com/cypress-io/cypress/issues/20222
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is disabled in browser runner window #20222

Open
saschwarz opened this issue Feb 16, 2022 · 1 comment
Open

Search is disabled in browser runner window #20222

saschwarz opened this issue Feb 16, 2022 · 1 comment

Comments

@saschwarz
Copy link

@saschwarz saschwarz commented Feb 16, 2022

Current behavior

Prior to 9.5.0(?) setting focus in the browser runner window and typing Cmd-F to search for text would search the text within the browser window. Now Cmd-F is captured and focus is shifted to the search bar in the Cypress app and the names of tests are searched.

I use search within the browser window as a normal part of my testing debugging workflow: to find specific steps, to find accessible roles that aren't matching exactly, to find logging, etc.

Desired behavior

Please restore the default browser search functionality

Test code to reproduce

No specific test code is required.

Cypress Version

9.5.0

Other

No response

@BlueWinds
Copy link
Contributor

@BlueWinds BlueWinds commented Feb 22, 2022

I agree this is not great usability.

It looks like this happened in #248, when we added test runner keyboard shortcuts (docs). In https://github.com/cypress-io/cypress/blob/develop/packages/reporter/src/lib/shortcuts.ts we're not checking for modifier keys (like ctrl) when deciding how to react to keypresses.

This is something we'd like to address, and I'll see when we can get to it; a pull request would be very welcome if anyone wants to create one, should be fairly straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants