close
The Wayback Machine - https://web.archive.org/web/20220409184320/https://github.com/infinitered/ignite/issues/1766
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash Screen label should match ignited app name #1766

Open
derekgreenberg opened this issue Aug 12, 2021 · 2 comments
Open

Splash Screen label should match ignited app name #1766

derekgreenberg opened this issue Aug 12, 2021 · 2 comments
Labels
good first issue

Comments

@derekgreenberg
Copy link
Member

@derekgreenberg derekgreenberg commented Aug 12, 2021 •
edited

Regardless of the name of the ignited app, the splash screen is set to "RnDiffApp"

Screen Shot 2021-08-12 at 11 40 38 AM

See LaunchScreen.storyboard :

<label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="RnDiffApp" textAlignment="center" lineBreakMode="middleTruncation" baselineAdjustment="alignBaselines" minimumFontSize="18" translatesAutoresizingMaskIntoConstraints="NO" id="GJd-Yh-RWb">

The text should be set to the name of the ignited app.
@derekgreenberg derekgreenberg added the good first issue label Aug 12, 2021
@himanshu007-creator
Copy link

@himanshu007-creator himanshu007-creator commented Aug 13, 2021

Hi, i would like to work on this issue

@dannyhw
Copy link
Contributor

@dannyhw dannyhw commented Mar 8, 2022

I think this can be closed since it looks like this is already handled by react-native-rename here:

ignite/src/commands/new.ts

Line 257 in c561e6a

const renameCmd = `npx react-native-rename@${cliDependencyVersions.rnRename} ${projectName} -b ${bundleIdentifier}`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@derekgreenberg @dannyhw @himanshu007-creator