UI: Fix show/hide toggle with minimize to taskbar #6057
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this change been tested on all 3 platforms, or just Linux? And on Linux, which DE? |
|
Just Linux on Ubuntu 21.10. |
|
Tested now on Windows 10 without problems |
|
Commit title needs improvement. |
If the user would minimize to tray instead of taskbar, the window would flash when clicking show in the tray menu, and the preview would be disabled. This would only happen on Linux.
cg2121
changed the title
|
Title has been updated. |
WizardCM
approved these changes
Mar 9, 2022
| @@ -8902,9 +8903,10 @@ void OBSBasic::SetShowing(bool showing) | |||
|
|
|||
| if (showHide) | |||
| showHide->setText(QTStr("Basic.SystemTray.Show")); | |||
| QTimer::singleShot(250, this, SLOT(hide())); | |||
| QTimer::singleShot(0, this, SLOT(hide())); | |||
There was a problem hiding this comment.
Does this actually still need to be in a QTimer if it's being triggered at a delay of 0, or is this more "rather not break anything unnecessarily" territory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
If the user would minimize to tray instead of taskbar, the
window would flash when clicking show in the tray menu, and
the preview would be disabled. This would only happen on Linux.
Motivation and Context
Fixes #3418
How Has This Been Tested?
Types of changes
Checklist: