close
The Wayback Machine - https://web.archive.org/web/20240715092643/https://github.com/TreasureProject/treasure-marketplace-contracts/issues/18
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no meaningful difference between createListing and updateListing #18

Closed
fulldecent opened this issue Mar 5, 2022 · 0 comments · Fixed by #31
Closed

There is no meaningful difference between createListing and updateListing #18

fulldecent opened this issue Mar 5, 2022 · 0 comments · Fixed by #31

Comments

@fulldecent
Copy link
Contributor

fulldecent commented Mar 5, 2022

The updateListing function (if properly implemented as documented) provides no additional functionality over createListing.

Unnecessary code duplication reduces code readability and increases risk of errors.

Recommendation: combine createListing and updateListing into a single function createListing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant