close
The Wayback Machine - https://web.archive.org/web/20210922010332/https://github.com/SeleniumHQ/selenium/pull/9244
Skip to content

/ selenium Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce select support for js #9244

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Introduce select support for js #9244

wants to merge 3 commits into from
+367 −0

Conversation

@luukvhoudt
Copy link

@luukvhoudt luukvhoudt commented Mar 8, 2021

Description

This PR is the start of the implementation for the select element support class for the JavaScript client. The global documentation already exists and can be found here. The lag of this feature is already noted in the code example boxes on this page. However issue #8721 also mentions this, however it was never solved because the issue lags a template.

Motivation and Context

Crucial feature for testing and automating.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
luukvhoudt added 2 commits Mar 8, 2021
@luukvhoudt
Introduced support for Select
f60631c
@luukvhoudt
Add license header
e45fda8
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 8, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Mar 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester
Copy link
Member

@AutomatedTester AutomatedTester commented Mar 10, 2021

this seems a great start. Let us know when the tests are completed and we can see about merging this PR

@AutomatedTester
Copy link
Member

@AutomatedTester AutomatedTester commented Jul 15, 2021

@luukvhoudt Are you going to be able to finish this PR?

@luukvhoudt
Copy link
Author

@luukvhoudt luukvhoudt commented Jul 15, 2021

@luukvhoudt Are you going to be able to finish this PR?

@AutomatedTester unfortunately not anytime soon, currently I also cannot really make an estimate when I will be able to finish this PR.

@AutomatedTester
Merge branch 'trunk' into introduce-select-support-for-js
3c976d5
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #9244 (3c976d5) into trunk (ad11a61) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #9244   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files          82       82           
  Lines        5445     5445           
  Branches      247      247           
=======================================
  Hits         2401     2401           
  Misses       2797     2797           
  Partials      247      247

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad11a61...3c976d5. Read the comment docs.

@AutomatedTester AutomatedTester mentioned this pull request Jul 19, 2021
Open
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Jul 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomatedTester AutomatedTester

Assignees
No one assigned
Labels
C-nodejs
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@luukvhoudt @CLAassistant @AutomatedTester @codecov-commenter @diemol