close
The Wayback Machine - https://web.archive.org/web/20220327013540/https://github.com/alan-turing-institute/sktime/issues/2270
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implement leakage-free imputation methods #2270

Open
4 tasks
fkiraly opened this issue Mar 21, 2022 · 2 comments
Open
4 tasks

[ENH] Implement leakage-free imputation methods #2270

fkiraly opened this issue Mar 21, 2022 · 2 comments
Labels
enhancement good first issue implementing algorithms module:forecasting

Comments

@fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Mar 21, 2022

The Imputer transformer has a lot of methods, but only few that are free of information leakage on a test set in the forecasting setting.

The simplest methods are implemented in #2269, but it would be nice to have more:

  • random_fit - like random, but uses min and max from fit
  • random_empirical - uses uniform sampling from the series seen in transform (this is leakage prone but should be there for completeness)
  • random_empirical_fit - uses uniform sampling from the series seen in fit
  • forecaster_fit - fits forecaster to data in fit, and uses predict to forecast indices with nan seen in transform

Implementation should branch off #2269 if not merged.

@fkiraly fkiraly added good first issue implementing algorithms module:forecasting enhancement labels Mar 21, 2022
@divo12
Copy link

@divo12 divo12 commented Mar 22, 2022

I wish to contribute on it

@aiwalter
Copy link
Collaborator

@aiwalter aiwalter commented Mar 22, 2022

I think we should rather implement this methods it fit as I described in the comments of #2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue implementing algorithms module:forecasting
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants