close
The Wayback Machine - https://web.archive.org/web/20221210204750/https://github.com/wesnoth/wesnoth/issues/6255
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to see the real add-on ids in the Add-ons Manager #6255

Open
irydacea opened this issue Nov 4, 2021 · 5 comments
Open

Make it possible to see the real add-on ids in the Add-ons Manager #6255

irydacea opened this issue Nov 4, 2021 · 5 comments
Labels
Add-ons Issues with the add-ons client and/or server. Enhancement Issues that are requests for new features or changes to existing ones. Good first issue Issues deemed adequate for contributors without prior experience to work on. UI User interface issues, including both back-end and front-end issues.

Comments

@irydacea
Copy link
Member

irydacea commented Nov 4, 2021

As the subject says, since right now it's pretty much impossible to find out the id of an add-on without downloading it, or changing log levels and then interacting with it in some specific way other than looking at its info on the UI.

(Perhaps hide them behind debug mode?)

@irydacea irydacea added Enhancement Issues that are requests for new features or changes to existing ones. UI User interface issues, including both back-end and front-end issues. Add-ons Issues with the add-ons client and/or server. Good first issue Issues deemed adequate for contributors without prior experience to work on. labels Nov 4, 2021
@haytham-med
Copy link

haytham-med commented Feb 7, 2022

Hi, what do you want id for?
it's usually used for porting

@soliton-
Copy link
Member

soliton- commented Feb 17, 2022

You need the ID for lots of interactions with the addon. Finding it in the filesystem, most commands for campaignd, using data/tools/wesnoth_addon_manager, etc.

There is no real way to identify an addon if the author changes the title for example or should two addons have the same icon, title, version etc. (all properties that can be chosen freely and need not be unique)...

The ID doesn't need to be prominently visible but it should be accessible somewhere (not behind debug mode IMO).

@zishiwu123
Copy link

zishiwu123 commented Aug 20, 2022

I'm not sure if this would be a good idea, but would it be possible to make a request to the add-on server for a list of all the add-on ids (and other info about the add-ons that might be needed)? Then store this in a add-ons.json file. When the game loads, it can check if this file exists already. If not make the request to get the data and create the file.

@Pentarctagon
Copy link
Member

Pentarctagon commented Aug 20, 2022

While that may be useful for something else to consume, the request here is simply to display the ID on the UI in the in-game add-ons manager.

As a side note as well, Wesnoth doesn't currently have any ability to write out in the JSON format - it uses WML (Wesnoth Markup Language), though the wmlparser3 script can convert to JSON (and XML).

@cooljeanius
Copy link
Contributor

cooljeanius commented Dec 9, 2022

(Perhaps hide them behind debug mode?)

Or an advanced preference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add-ons Issues with the add-ons client and/or server. Enhancement Issues that are requests for new features or changes to existing ones. Good first issue Issues deemed adequate for contributors without prior experience to work on. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

No branches or pull requests

6 participants