close
The Wayback Machine - https://web.archive.org/web/20201130060942/https://github.com/vercel/next.js/issues/15542
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Recommend CSS Modules over css-in-js #15542

Open
lfades opened this issue Jul 27, 2020 · 1 comment
Open

[Docs] Recommend CSS Modules over css-in-js #15542

lfades opened this issue Jul 27, 2020 · 1 comment

Comments

@lfades
Copy link
Member

@lfades lfades commented Jul 27, 2020

It has been mentioned multiple times on feedback that in the documentation for Built-In CSS Support we don't really recommend CSS Modules over CSS-in-JS, therefore we create confusion about what should be used if both methods handle the same thing.

We should update the page to be clear about the advantages of CSS Modules over css-in-js, mainly being that you don't need JS to add the CSS as CSS Modules are concatenated into many minified and code-split .css files. Ideally users should end up thinking that CSS Modules are the preferred solution, but any CSS-in-JS library is also an option.

@lfades lfades self-assigned this Jul 27, 2020
@lfades lfades changed the title [Docs] Be more clear on the differences between CSS Modules and css-in-js [Docs] Recommend CSS Modules over css-in-js Jul 27, 2020
@Timer Timer added this to the backlog milestone Sep 7, 2020
@hiroppy
Copy link

@hiroppy hiroppy commented Nov 30, 2020

As far as I know, webpack team wants to drop css-modules from css-loader but do you plan to implement css-modules on Next.js?

FYI: webpack-contrib/css-loader#1050 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.