Add isErrorLike() method
#68
Conversation
|
You need to update the readme too. |
Sure, but we still need to keep the loose variant around for |
For now I added the
|
index.d.ts
Outdated
| stack: string; | ||
| message: string; | ||
| code?: string; | ||
| } & JsonObject; |
There was a problem hiding this comment.
& JsonObject is not correct here because the JS code is not actually ensuring that.
There was a problem hiding this comment.
Should we also add cause as optional? Same with ErrorObject.
There was a problem hiding this comment.
& JsonObject is not correct here because the JS code is not actually ensuring that.
I suppose the solution is to use a generic Record then
Should we also add cause as optional? Same with ErrorObject.
Done
index.d.ts
Outdated
| Predicate to determine whether a value looks like an error, even if it's not an instance of `Error`. It must have at least the `name`, `message`, and `stack` properties. | ||
| @example | ||
| ```js |
There was a problem hiding this comment.
The rest of the examples use ``` too. I dropped js though.
If you want to drop ``` from all of them it can be done in a separate commit I suppose
There was a problem hiding this comment.
If you want to drop ``` from all of them it can be done in a separate commit I suppose
| }); | ||
| //=> false | ||
| ``` | ||
|
Sorry for the back and forth. I would make the changes myself, but I don't have access since you did the PR from an org account. |
Ahh that's annoying, sorry about that |
Closes #47
Since
deserializeErroralso acceptsErrorinstances, I decided to do the same for this detector.Names:
trueor real arraysErrorinstancesErrorObjecttype, but it reads like "isErrorobject", as in "isErrorinstance.Unrelated suggestions:
ErrorObjecttype toErrorLikename,messageandstackproperties of this type mandatory, because they always exist innew Error()and its serialized counterpart