close
The Wayback Machine - https://web.archive.org/web/20210613220308/https://github.com/pytorch/fairseq/issues/1357
Skip to content

/ fairseq

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hub access is broken by PR1219. #1357

Closed
ailzhang opened this issue Nov 8, 2019 · 2 comments
Closed

Hub access is broken by PR1219. #1357

ailzhang opened this issue Nov 8, 2019 · 2 comments

Comments

@ailzhang
Copy link

@ailzhang ailzhang commented Nov 8, 2019

#1219 broke hub.
Repro:
en2fr = torch.hub.load('pytorch/fairseq', 'transformer.wmt14.en-fr', tokenizer='moses', bpe='subword_nmt')
Error message:

---> 27             from subword_nmt.subword_nmt import apply_bpe
     28             bpe_parser = apply_bpe.create_parser()

ModuleNotFoundError: No module named 'subword_nmt'

During handling of the above exception, another exception occurred:

Also would you mind adding hub command into CI if you have one? ;D Thanks!
@ailzhang ailzhang mentioned this issue Nov 8, 2019
Merged
@myleott
Copy link
Contributor

@myleott myleott commented Nov 13, 2019

Thanks for flagging, I'll submit a fix shortly and add some tests for hub commands.
@myleott
Copy link
Contributor

@myleott myleott commented Nov 14, 2019

Fixed in e404785
@myleott myleott closed this Nov 14, 2019
facebook-github-bot added a commit that referenced this issue Oct 19, 2020
@myleott @facebook-github-bot
Apply black+isort (#1357)
Loading status checks…
a48f235 
Summary: Pull Request resolved: fairinternal/fairseq-py#1357

Reviewed By: alexeib

Differential Revision: D24377772

fbshipit-source-id: 51581af041d42d62166b33a35a1a4228b1a76f0c
sshleifer pushed a commit that referenced this issue Apr 7, 2021
@myleott @facebook-github-bot
Apply black+isort (#1357)
fd7ca78 
Summary: Pull Request resolved: fairinternal/fairseq-py#1357

Reviewed By: alexeib

Differential Revision: D24377772

fbshipit-source-id: 51581af041d42d62166b33a35a1a4228b1a76f0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@myleott @ailzhang