close
The Wayback Machine - https://web.archive.org/web/20220217151819/https://github.com/openfaas/faas-netes/issues/895
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingressClassName when deploying an Ingress #895

Open
1 of 2 tasks
aureq opened this issue Jan 18, 2022 · 1 comment
Open
1 of 2 tasks

Support ingressClassName when deploying an Ingress #895

aureq opened this issue Jan 18, 2022 · 1 comment

Comments

@aureq
Copy link

@aureq aureq commented Jan 18, 2022

Expected Behaviour

Currently, it appears that the OpenFaaS Helm Chart doesn't support the Ingress property named spec.ingressClassName.

As of k8s 1.22, the api networking.k8s.io/v1 is the default api for ingress objects and as such uses the ingressClassName field rather than annotations.

Current Behaviour

The current chart doesn't support the ingressClassName.

Are you a GitHub Sponsor (Yes/No?)

Check at: https://github.com/sponsors/openfaas

  • Yes
  • No

Context

Ingress-nginx has posted a FAQ here https://kubernetes.github.io/ingress-nginx/

Thank you for considering this issue.

@LucasRoesler
Copy link
Member

@LucasRoesler LucasRoesler commented Feb 17, 2022

This seems like it should be an easy first issue, we need only need to add a small if block to the ingress right before teh rules:

{{- if .Values.ingress.ingressClassName }}
ingressClassName: {{ .Values.ingress.ingressClassName }}
{{- end }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants