Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
build: fix corehost.proj dac injection unquoted path #67467
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftbot
bot
added
the
community-contribution
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsWith a clean current repo running build.cmd resulted in this error: I used the binlog to track that back to
|
EgorBo
reviewed
Apr 1, 2022
| @@ -39,7 +39,7 @@ | |||
| Condition="'$(RuntimeFlavor)' != 'Mono'"> | |||
| <Copy SourceFiles="$(SingleFileHostPath);$(SingleFileHostSymbolsPath)" DestinationFiles="$(SingleFileHostDestinationPath);$(SingleFileHostSymbolsPath)" /> | |||
| <Exec Condition="'$(TargetOS)' == 'windows'" | |||
| Command="$(NetCoreRoot)dotnet exec @(InjectResourceTool) --bin "$(DacPath)" --image "$(SingleFileHostDestinationPath)" --name MINIDUMP_EMBEDDED_AUXILIARY_PROVIDER" /> | |||
| Command=""$(NetCoreRoot)dotnet" exec @(InjectResourceTool) --bin "$(DacPath)" --image "$(SingleFileHostDestinationPath)" --name MINIDUMP_EMBEDDED_AUXILIARY_PROVIDER" /> | |||
There was a problem hiding this comment.
can it use $(DotNetTool) here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With a clean current repo running build.cmd resulted in this error:
E:\Programming\csharp7\runtime\src\native\corehost\corehost.proj(41,5): error MSB3073: The command "C:\Program Files\dotnet\dotnet exec E:\Programming\csharp7\runtime\artifacts\bin\coreclr\windows.x64.Debug\InjectResource\InjectResource.dll --bin "E:\Programming\csharp7\runtime\artifacts\bin\coreclr\windows.x64.Debug\/mscordaccore.dll" --image "E:\Programming\csharp7\runtime\artifacts\bin\win-x64.Debug\corehost\/singlefilehost.exe" --name MINIDUMP_EMBEDDED_AUXILIARY_PROVIDER" exited with code 9009. [E:\Programming\csharp7\runtime\src\native\corehost\corehost.proj]I used the binlog to track that back to
PrepareSingleFileHostWithEmbeddedDacCorewhich has an exec command that uses the systemwide location of dotnet.exe without quoting it. This fixes it.