close
The Wayback Machine - https://web.archive.org/web/20220411002048/https://github.com/tutao/tutanota/issues/3311
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to FAQ are not always displayed as URL in Settings #3311

Open
vitoreiji opened this issue Jul 22, 2021 · 4 comments
Open

Links to FAQ are not always displayed as URL in Settings #3311

vitoreiji opened this issue Jul 22, 2021 · 4 comments
Labels
bug good first issue improvement

Comments

@vitoreiji
Copy link
Contributor

@vitoreiji vitoreiji commented Jul 22, 2021

Most of the time we display FAQ links as raw URLs, like this:

image

But in some places (at least in Settings → Subscription → Gift cards) we just make it a link with a text.

image

This should be more consistent.

@vitoreiji vitoreiji added bug improvement good first issue labels Jul 22, 2021
@prnam
Copy link

@prnam prnam commented Sep 11, 2021

How do you like it to be, @vitoreiji ? 🙂

Idea of client rendering the FAQ url is great option if context switching is priority; if transparency is priority then we need to use full web address.

In either case, we do not have translations for FAQ's and we need to rewrite FAQ url with concat of translation code between domain and FAQ path, to make it future proof.

Happy to contribute on this issue 🐞

@vitoreiji
Copy link
Contributor Author

@vitoreiji vitoreiji commented Sep 28, 2021

Personally I think text links look cleaner, but I don't feel that strongly about it. I don't think there is any difference regarding transparency.

In either case, we do not have translations for FAQ's and we need to rewrite FAQ url with concat of translation code between domain and FAQ path, to make it future proof.

That's a good idea, adapting the links to the user's language to point to the FAQ in the correct language. Currently the links always go to the English FAQ.

Happy to contribute on this issue lady_beetle

That's great, thanks!

@prnam
Copy link

@prnam prnam commented Dec 13, 2021

Hey @vitoreiji ,
Please accept my apologies for delay in contributing on this issue. I just started to working on this few mins ago to make necessary changes.

  • Change will be as below for Gift Cards -

after-change-gift-cards-terms

  • Change in Spam rules as below -

before-spam-rule-change

after-spam-rule-change

Please let me know if above is fine with you.

Help Needed - w.r.t Whitelabel. It would involve modifying translation if we replace "please see" to "more Info" with long sentence, if you want me to remove whole sentence and replace and keep it consistent like others then it will be straight forward change. Let me know you thoughts.

before-whitelabel-change

Anything if I missed as part of this change let me know, will commit & push as soon as I have your final view on this.

@prnam
Copy link

@prnam prnam commented Dec 18, 2021

Hey @vitoreiji @charlag @bedhub ,
#3744 - is related this issue. White label is untouched. If needs to be reworked or anything missed (as requested above) please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue improvement
Projects
None yet
Development

No branches or pull requests

2 participants