close
The Wayback Machine - https://web.archive.org/web/20200918173453/https://github.com/infinitered/apisauce/issues/213
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiResponse.config should not be optional #213

Open
shmargum opened this issue May 16, 2019 · 1 comment
Open

ApiResponse.config should not be optional #213

shmargum opened this issue May 16, 2019 · 1 comment

Comments

@shmargum
Copy link

@shmargum shmargum commented May 16, 2019

From what I can tell, the ApiResponse objects can never have an undefined config.

Config is defined as optional here:
https://github.com/infinitered/apisauce/blob/master/apisauce.d.ts#L44
But is required here:
https://github.com/infinitered/apisauce/blob/master/lib/apisauce.ts#L200

@kartik-budhiraja
Copy link

@kartik-budhiraja kartik-budhiraja commented Oct 23, 2019

@robinheinze, @ryanlntn Can I work on this issue if it's up for grabs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.